Rather than attempt to judge the labs in question, I'll address how you can evaluate the needs of your students, and what labs they need to be given.
The labs from the College Board are, as you indicated, suggestions rather than requirements. The implication is that if those labs are completed successfully the students will be prepared for related questions on the College Board's exams. The design of those labs, presumably, address the minimum competencies a student needs to pass the College Board exams. They are most likely also designed around the typical student enrolled in an AP CS A course at the high-school level. All well and good for the instructor with a class filled with these mythological typical students.
Your students are not typical. They are not average, and they are not "in the norm." That's true for every instructor, so I'm not placing your class above, or below, typical; rather I'm saying that typical is a statistical contrivance, not reality. In the process of designing your course, including the labs to use, you get to take advantage of what you know about your student body that the College Board does not know. You know what their prior course work has been focused on. You know what other fields of study have been presented, and at what level, before they are enrolled in the AP CS A course in your school. Things like first exposure to Java vs. continuation of Java work, prior basic algebra vs. plane geometry and trig., other languages learned, prerequisite courses in your system for the AP CS A course, etc. You also know what you, your school, your school district, and your state education system expect to be presented, and what the stated "objectives" are for your class, and the program it is part of.
What the established objectives are for your course, no matter at what level they have been "established", determines what the course content is. The labs have to mesh well with the course as a whole if they are to have an effective impact on the students reaching the objectives. If your class is the third in a series of Java classes, a lab that explores looping structures will have very little value. Conversely, if it is their first exposure to Java, than a lab that implements a 3-dimensional graphics class will probably never be completed successfully.
Once you have settled how the labs will mesh with the course content, and what level of competency you can anticipate from your students, you can evaluate, or design, labs that further the objectives of your course.
Obviously, since it is an AP CS A course, passing the College Board exam is included in the objectives. It can, however, be the final goal, or it can be the minimum requirement. If your objective is to prepare the students for advanced studies in CS you do not, and probably should not, limit your labs to mirror the minimum set by the sample labs. Instead you can build labs that allow the students to practice what they've been taught, even if it's beyond the College Board minimums, and expands their mental skills in a way the prepares them to learn new concepts after they've mastered what you offer.
It's a difference between "teaching the test" and "teaching the subject." An unfortunate trend has been growing where states, or the College Board, have established some set of "minimum passing" evaluations, or standardized tests for graduation. In order to assure that students get high marks on those tests, meaning better ranking for their school, and maybe better funding from the state, the instructors have started to teach what's on the test, and nothing more. That is a major disservice to the students, even if it does increase funding for the schools.
For evaluation of any lab assignment, College Board example, random Internet find, or custom built, there are three basic criteria to apply:
- Does it require the students to fully utilize, and demonstrate,
what the course has covered thus far?
- Does it set the stage, and prepare the students for the the
concepts presented in the next segment of the course?
- Does it encourage practices, and mental skills, that will be beneficial to the students in the future - either in other CS courses or in everyday life?
Of course, after evaluating one lab, you can always evaluate other labs, and rather than answering the questions above in a binary, yes/no, fashion, you can answer them on a scale of effectiveness in meeting those criteria. If the labs presented by the College Board meet the needs of_your_ students, and the objectives of your course, then they are a good choice, regardless of the reviews from publishers, who may have their own labs to sell, or even instructors in other schools, who may have other objectives, and surely have different student bodies to work with.